Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1586] Add available workers Metrics #2723

Closed
wants to merge 4 commits into from

Conversation

zaynt4606
Copy link
Contributor

@zaynt4606 zaynt4606 commented Sep 3, 2024

What changes were proposed in this pull request?

Currently metrics have workers and excludedWorkers and other metadata for master service but don't have metadata for available workers. This PR supplemented this part.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Local test
image

@SteNicholas SteNicholas changed the title [CELEBORN-1586]Add available workers Metrics [CELEBORN-1586] Add available workers Metrics Sep 3, 2024
Copy link
Contributor

@RexXiong RexXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls use Grafana to test the dashboard.json

@RexXiong RexXiong closed this in 59a3995 Sep 5, 2024
@RexXiong
Copy link
Contributor

RexXiong commented Sep 5, 2024

Merge to main(v0.6.0)

s0nskar pushed a commit to s0nskar/celeborn that referenced this pull request Sep 16, 2024
### What changes were proposed in this pull request?
Currently metrics have workers and excludedWorkers and other metadata for master service but don't have metadata for available workers. This PR supplemented this part.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Local test
![image](https://github.com/user-attachments/assets/240c176c-4eef-4e3c-b34d-802291714702)

Closes apache#2723 from zaynt4606/availableWorker.

Authored-by: szt <[email protected]>
Signed-off-by: Shuang <[email protected]>
wankunde pushed a commit to wankunde/celeborn that referenced this pull request Oct 11, 2024
### What changes were proposed in this pull request?
Currently metrics have workers and excludedWorkers and other metadata for master service but don't have metadata for available workers. This PR supplemented this part.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Local test
![image](https://github.com/user-attachments/assets/240c176c-4eef-4e3c-b34d-802291714702)

Closes apache#2723 from zaynt4606/availableWorker.

Authored-by: szt <[email protected]>
Signed-off-by: Shuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants