[CELEBORN-1589] Ensure master is leader for some POST request APIs #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
reviewed
Sep 10, 2024
...er/src/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/WorkerResource.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Sep 10, 2024
...er/src/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/WorkerResource.scala
Outdated
Show resolved
Hide resolved
added 2 commits
September 10, 2024 16:36
turboFei
reviewed
Sep 11, 2024
.../main/scala/org/apache/celeborn/service/deploy/master/http/api/MasterHttpResourceUtils.scala
Outdated
Show resolved
Hide resolved
added 2 commits
September 10, 2024 17:07
mridulm
reviewed
Sep 11, 2024
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
.../main/scala/org/apache/celeborn/service/deploy/master/http/api/MasterHttpResourceUtils.scala
Show resolved
Hide resolved
mridulm
approved these changes
Sep 11, 2024
|
Merged to main(v0.6.0). |
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? Ensure that `excludeWorker`, `removeWorkersUnavailableInfo`, and `sendWorkerEvents` can only happen from Master leader node. ### Why are the changes needed? prevent inconsistencies from peers ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? tested against a cluster Closes apache#2730 from akpatnam25/CELEBORN-1589. Authored-by: Aravind Patnam <[email protected]> Signed-off-by: SteNicholas <[email protected]>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? Ensure that `excludeWorker`, `removeWorkersUnavailableInfo`, and `sendWorkerEvents` can only happen from Master leader node. ### Why are the changes needed? prevent inconsistencies from peers ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? tested against a cluster Closes apache#2730 from akpatnam25/CELEBORN-1589. Authored-by: Aravind Patnam <[email protected]> Signed-off-by: SteNicholas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure that
excludeWorker,removeWorkersUnavailableInfo, andsendWorkerEventscan only happen from Master leader node.Why are the changes needed?
prevent inconsistencies from peers
Does this PR introduce any user-facing change?
No
How was this patch tested?
tested against a cluster