Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1606] Generate dependencies-client-flink-1.16 #2751

Closed
wants to merge 1 commit into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Sep 20, 2024

What changes were proposed in this pull request?

Why are the changes needed?

CELEBORN-1504 supports Flink 1.16, but dependencies-client-flink-1.16 is not generated. dependencies.sh will pass the file non-existence check.

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged into main(v0.6.0).

@FMX FMX closed this in 6e07134 Sep 23, 2024
HolyLow pushed a commit to HolyLow/celeborn that referenced this pull request Oct 14, 2024
### What changes were proposed in this pull request?

### Why are the changes needed?
CELEBORN-1504 supports Flink 1.16, but `dependencies-client-flink-1.16` is not generated. dependencies.sh will pass the file non-existence check.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
GA

Closes apache#2751 from cxzl25/CELEBORN-1606.

Authored-by: sychen <[email protected]>
Signed-off-by: mingji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants