Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1525] Bump Ratis version from 3.1.0 to 3.1.1 #2759

Closed
wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Sep 24, 2024

What changes were proposed in this pull request?

Bump Ratis version from 3.1.0 to 3.1.1 including:

Why are the changes needed?

Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to 3.1.1. The 3.1.1 version is a minor release with multiple improvements and bugfixes including [RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely, [RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host. See the changes between 3.1.0 and 3.1.1 releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@SteNicholas SteNicholas marked this pull request as draft September 24, 2024 07:02
@mridulm
Copy link
Contributor

mridulm commented Sep 25, 2024

In description, diff of changes between the two versions, would be apache/ratis@release-3.1.0...release-3.1.1 ?
Our changes look good to me ... the test failure looks relevant though.

@SteNicholas
Copy link
Member Author

@mridulm, Ratis 3.1.1 version will release this week. Therefore, I converted this pull request to draft. Meanwhile, I used Ratis v3.1.1-rc3 version to test this bumping firstly.

@mridulm
Copy link
Contributor

mridulm commented Sep 25, 2024

The test failures look related to RATIS-2135

@SteNicholas SteNicholas marked this pull request as ready for review September 26, 2024 06:47
@SteNicholas
Copy link
Member Author

SteNicholas commented Sep 26, 2024

The test failures look related to RATIS-2135

@mridulm, I have supported that raft.grpc.message.size.max must be 1m larger than raft.server.log.appender.buffer.byte-limit for RATIS-2135. PTAL.
BTW, Release 3.1.1 is available: Release 3.1.1 is available.
cc @FMX, @RexXiong, @szetszwo.

pom.xml Show resolved Hide resolved
Copy link

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Copy link
Contributor

@mridulm mridulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mridulm mridulm closed this in 651cbeb Sep 26, 2024
@mridulm
Copy link
Contributor

mridulm commented Sep 26, 2024

Merged to master.
Thanks for fixing it @SteNicholas !
Thanks for reviews @cxzl25 , @szetszwo :-)

HolyLow pushed a commit to HolyLow/celeborn that referenced this pull request Oct 14, 2024
### What changes were proposed in this pull request?

Bump Ratis version from 3.1.0 to 3.1.1 including:

- Remove `address2String` and use `setAddress(ratisAddr)` with the release of apache/ratis#1125.
- Support `raft.grpc.message.size.max` must be 1m larger than `raft.server.log.appender.buffer.byte-limit` for apache/ratis#1132.

### Why are the changes needed?

Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to [3.1.1](https://ratis.apache.org/post/3.1.1.html). The 3.1.1 version is a minor release with multiple improvements and bugfixes including [[RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely](https://issues.apache.org/jira/browse/RATIS-2116), [[RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host](https://issues.apache.org/jira/browse/RATIS-2131). See the [changes between 3.1.0 and 3.1.1](apache/ratis@ratis-3.1.0...ratis-3.1.1) releases.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.

Closes apache#2759 from SteNicholas/CELEBORN-1525.

Authored-by: SteNicholas <[email protected]>
Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants