-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1525] Bump Ratis version from 3.1.0 to 3.1.1 #2759
Conversation
In description, diff of changes between the two versions, would be apache/ratis@release-3.1.0...release-3.1.1 ? |
@mridulm, Ratis 3.1.1 version will release this week. Therefore, I converted this pull request to draft. Meanwhile, I used Ratis v3.1.1-rc3 version to test this bumping firstly. |
The test failures look related to RATIS-2135 |
c69faa6
to
ad92168
Compare
@mridulm, I have supported that |
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java
Show resolved
Hide resolved
ad92168
to
059f9fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Merged to master. |
### What changes were proposed in this pull request? Bump Ratis version from 3.1.0 to 3.1.1 including: - Remove `address2String` and use `setAddress(ratisAddr)` with the release of apache/ratis#1125. - Support `raft.grpc.message.size.max` must be 1m larger than `raft.server.log.appender.buffer.byte-limit` for apache/ratis#1132. ### Why are the changes needed? Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to [3.1.1](https://ratis.apache.org/post/3.1.1.html). The 3.1.1 version is a minor release with multiple improvements and bugfixes including [[RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely](https://issues.apache.org/jira/browse/RATIS-2116), [[RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host](https://issues.apache.org/jira/browse/RATIS-2131). See the [changes between 3.1.0 and 3.1.1](apache/ratis@ratis-3.1.0...ratis-3.1.1) releases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2759 from SteNicholas/CELEBORN-1525. Authored-by: SteNicholas <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
What changes were proposed in this pull request?
Bump Ratis version from 3.1.0 to 3.1.1 including:
address2String
and usesetAddress(ratisAddr)
with the release of RATIS-2131: Surround with [] only if hostName is a IPv6 string ratis#1125.raft.grpc.message.size.max
must be 1m larger thanraft.server.log.appender.buffer.byte-limit
for RATIS-2135. The leader keeps sending inconsistent entries repeatedly to followers. ratis#1132.Why are the changes needed?
Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to 3.1.1. The 3.1.1 version is a minor release with multiple improvements and bugfixes including [RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely, [RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host. See the changes between 3.1.0 and 3.1.1 releases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.