Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1616] Shade com.google.thirdparty to prevent dependency conflicts #2765

Closed
wants to merge 1 commit into from

Conversation

akpatnam25
Copy link
Contributor

What changes were proposed in this pull request?

shade com.google.thirdparty

Why are the changes needed?

prevent dependency conflicts

Does this PR introduce any user-facing change?

no

How was this patch tested?

will let CI run

@akpatnam25
Copy link
Contributor Author

@akpatnam25 akpatnam25 marked this pull request as ready for review September 26, 2024 07:39
Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.6.0).

@FMX FMX closed this in 3b6dc5b Sep 27, 2024
HolyLow pushed a commit to HolyLow/celeborn that referenced this pull request Oct 14, 2024
…flicts

### What changes were proposed in this pull request?
shade `com.google.thirdparty`

### Why are the changes needed?
prevent dependency conflicts

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
will let CI run

Closes apache#2765 from akpatnam25/CELEBORN-1616.

Authored-by: Aravind Patnam <[email protected]>
Signed-off-by: mingji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants