[CELEBORN-1644] Optimize handle merged data on stage end #2806
+50
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
reviewed
Oct 12, 2024
| .add(mapId); | ||
| if (response.remaining() > 0) { | ||
| int retCode = response.get(); | ||
| if (retCode == StatusCode.MAP_ENDED.getValue()) { |
There was a problem hiding this comment.
Is there any compatibility problem between old client version and new server version, which situation is that server returns STAGE_ENDED but client only handles MAP_ENDED?
There was a problem hiding this comment.
STAGE_ENDED will be returned if the field stageEnd is true. So old servers won't return STAGE_ENDED.
RexXiong
reviewed
Oct 15, 2024
| @@ -490,7 +492,14 @@ class PushDataHandler(val workerSource: WorkerSource) extends BaseMessageHandler | |||
| ByteBuffer.wrap(Array[Byte](StatusCode.HARD_SPLIT.getValue))) | |||
| } | |||
| } else { | |||
| if (storageManager.shuffleKeySet().contains(shuffleKey)) { | |||
| // This means that this stage is ended and invoked commit files by stage end | |||
| if (presumptiveEndedShuffles.contains(shuffleKey)) { | |||
There was a problem hiding this comment.
Seems we can check stage_end before checking map_end?
RexXiong
reviewed
Oct 15, 2024
| .computeIfAbsent(shuffleId, (id) -> ConcurrentHashMap.newKeySet()) | ||
| .add(mapId); | ||
| } | ||
| if (retCode == StatusCode.STAGE_ENDED.getValue()) { |
RexXiong
reviewed
Oct 15, 2024
| @@ -490,6 +498,7 @@ class PushDataHandler(val workerSource: WorkerSource) extends BaseMessageHandler | |||
| ByteBuffer.wrap(Array[Byte](StatusCode.HARD_SPLIT.getValue))) | |||
| } | |||
| } else { | |||
| // This means that this stage is ended and invoked commit files by stage end | |||
| @@ -439,7 +442,7 @@ abstract class CommitHandler( | |||
| replicaIds) | |||
| } | |||
|
|
|||
| doParallelCommitFiles(shuffleId, shuffleCommittedInfo, params, commitFilesFailedWorkers) | |||
| doParallelCommitFiles(shuffleId, shuffleCommittedInfo, params, commitFilesFailedWorkers, true) | |||
There was a problem hiding this comment.
Only the ReducePartitionCommitHandler can set stageEnd to true when call handleFinalCommitFiles method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Committing files will take a period of time if a speculation task is pushing merged data to the worker. This will cause the client to retry until the committing files is complete or client timeout. This PR intend to optimize the logic to avoid unnecessary retry.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA.