Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1645] Introduce ShuffleFallbackPolicy to support custom implementation of shuffle fallback policy for CelebornShuffleFallbackPolicyRunner #2807

Closed
wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

What changes were proposed in this pull request?

Introduce ShuffleFallbackPolicy to support custom implementation of shuffle fallback policy for CelebornShuffleFallbackPolicyRunner.

Why are the changes needed?

Shuffle fallback policy is fixed in CelebornShuffleFallbackPolicyRunner, which could not support user-defined fallback policy implementation. It's proposed to introduce ShuffleFallbackPolicy to support custom implementation of shuffle fallback policy for CelebornShuffleFallbackPolicyRunner.

Does this PR introduce any user-facing change?

Introduce ShuffleFallbackPolicy interface to determine whether fallback to vanilla Spark built-in shuffle implementation.

/**
 * The shuffle fallback policy determines whether fallback to vanilla Spark built-in shuffle
 * implementation.
 */
public interface ShuffleFallbackPolicy {

  /**
   * Returns whether fallback to vanilla spark built-in shuffle implementation.
   *
   * @param shuffleDependency The shuffle dependency of Spark.
   * @param celebornConf The configuration of Celeborn.
   * @param lifecycleManager The {@link LifecycleManager} of Celeborn.
   * @return Whether fallback to vanilla spark built-in shuffle implementation.
   */
  boolean needFallback(
      ShuffleDependency<?, ?, ?> shuffleDependency,
      CelebornConf celebornConf,
      LifecycleManager lifecycleManager);
}

How was this patch tested?

SparkShuffleManagerSuite

@SteNicholas
Copy link
Member Author

Ping @FMX, @RexXiong.

@photogamerun
Copy link

it is Awsome @SteNicholas

…lementation of shuffle fallback policy for CelebornShuffleFallbackPolicyRunner
Copy link
Contributor

@RexXiong RexXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge to main(v0.6.0)

@RexXiong RexXiong closed this in 298eadb Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants