Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Add multiple operating system source code to compile CBDB #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Baowen648
Copy link
Contributor

Multiple operating systems include:
ubuntu:24.04
ubuntu:22.04
ubuntu:20.04
debian:12
debian:11
oraclelinux:9
fedora:39
fedora:38
openeuler:24.03
openeuler:22.03

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

compile CBDB

Multiple operating systems include:
  ubuntu:24.04
  ubuntu:22.04
  ubuntu:20.04
  debian:12
  debian:11
  oraclelinux:9
  fedora:39
  fedora:38
  openeuler:24.03
  openeuler:22.03
Copy link
Contributor

@edespino edespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered splitting this into multiple GitHub Action Matrix Workflows?

  • I suggest maintaining a distinct build container Dockerfile supporting a list of CBDB supported OSs. This allows anyone to create a build environment easily for any supported OS by referencing the Dockerfile or by simply use a previously published build container. It would also be easier to diagnose build issues. It would bring build environment consistentcy. This is not possible with the matrix workflow approach.
  • A separate GitHub Action Matrix Workflow would build and publish the custom CBDB build containers. Each container would contain the required build time dependencies. The containers could get rebuilt if the Dockerfile definition changes. It could also possibly build on a weekly basis to ensure they can be rebuilt reliably.
  • The CBDB configure, make and make install operations could then be performed in the corresponding pre-built build containers.
  • Time and resources are wasted installing these packages over and over again across all platforms.
  • Do we really need to build on 10 platforms? Initially, I recommend building on 4 OSs - Ubuntu 22.04, Debian 12, AlmaLinux 9, OpenEuler 22.03

@my-ship-it
Copy link
Contributor

Happy to see the PR since multiple operating systems are supported.
Any progress on it?

@my-ship-it
Copy link
Contributor

@Zhangbaowen-Hashdata Any progress on it?

@my-ship-it my-ship-it changed the title Add multiple operating system source code to compile CBDB [WIP]Add multiple operating system source code to compile CBDB Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants