Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error when disable-faultinjector #660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roseduan
Copy link
Contributor

@roseduan roseduan commented Oct 10, 2024

A compile error will occur when --disable-faultinjector option is added to the compilation parameters.

Discussion: #555

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@roseduan roseduan force-pushed the fix_disable_faultinjector_error branch 2 times, most recently from e7cf12b to 8f58229 Compare November 11, 2024 07:31
gfphoenix78
gfphoenix78 previously approved these changes Nov 11, 2024
Copy link
Contributor

@gfphoenix78 gfphoenix78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A compile error will occur when --disable-faultinjector option is added
to the compilation parameters.

Discussion: apache#555
@roseduan roseduan force-pushed the fix_disable_faultinjector_error branch from 4583b52 to 5d2e427 Compare November 27, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants