-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AQUMV]Enable answer query using Materialized View for external table. #702
base: main
Are you sure you want to change the base?
Conversation
see more details in #693 |
PostgreSQL-style GUC would have name like enable_XXX, huh? So, maybe enable_aqumv_foreign_table |
Not sure.. I follow this one: |
@@ -151,6 +151,9 @@ answer_query_using_materialized_views(PlannerInfo *root, | |||
has_subclass(origin_rel_oid)) | |||
return mv_final_rel; | |||
|
|||
if (get_rel_relkind(origin_rel_oid) == RELKIND_FOREIGN_TABLE && !aqumv_allow_foreign_table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create readable external table aqumv_ext_r ()
can we get readable
from table ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GP forbids creating a matview as select from writable external table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create readable external table aqumv_ext_r(id int)
location ('demoprot://aqumvtextfile.txt') format 'text';
- can we mantain
aqumvtextfile.txt
status ingp_matview_aux
use file timestamp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just an example, they could be files, remote servers or another databases outside CBDB. You couldn't know the status of them and pointless for that. See more in #693
@my-ship-it So, we should skip fast path for the views have external tables. That need catalog change to record if a view has external tables outside CBDB. |
Yes, I think it is a reasonable behavior. Thanks! |
Allow answer query using materialized views which have external or foreign tables. Since we don't know if the data is up to date of externel table outside CBDB, introduce a new GUC: aqumv_allow_foreign_table Let user decide if they want to use matview instead of query on external tables. create materialized view aqumv_ext_mv as select * from aqumv_ext_r; explain (costs off, verbose) select * from aqumv_ext_r; QUERY PLAN ------------------------------------------ Gather Motion 3:1 (slice1; segments: 3) Output: id -> Seq Scan on aqumv.aqumv_ext_mv Output: id Optimizer: Postgres query optimizer Index could also be used if there were on matviews. create index on aqumv_ext_mv(id); explain (costs off, verbose) select * from aqumv_ext_r where id = 5; QUERY PLAN ---------------------------------------------------------------------- Gather Motion 1:1 (slice1; segments: 1) Output: id -> Index Only Scan using aqumv_ext_mv_id_idx on aqumv.aqumv_ext_mv Output: id Index Cond: (aqumv_ext_mv.id = 5) Optimizer: Postgres query optimizer
Authored-by: Zhang Mingli [email protected]
Done in 273dae1, |
Allow answer query using materialized views which have external or foreign tables.
Since we don't know if the data is up to date of externel table outside CBDB, introduce a new GUC:
aqumv_allow_foreign_table
Let user decide if they want to use matview instead of query on external tables.
Index could also be used if there were on matviews.
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳