Fix REFRESH fast path. #720
Conversation
|
This is a cherry-pick commit from commercial version. |
|
|
||
| Form_gp_matview_aux auxform = (Form_gp_matview_aux) GETSTRUCT(mvauxtup); | ||
| return (auxform->datastatus == MV_DATA_STATUS_UP_TO_DATE); | ||
| } |
There was a problem hiding this comment.
That function is differ from MatviewIsGeneralyUpToDate only in predicate || auxform->datastatus == MV_DATA_STATUS_UP_REORGANIZED
Maybe it would be better to create function like matviewCheckForDataStatuses(Oid mvoid, char[] statuses) and not to duplicate steps to get Form_gp_matview_aux structure
There was a problem hiding this comment.
HI, @leborchuk thanks for review.
Maybe it would be better to create function like matviewCheckForDataStatuses(Oid mvoid, char[] statuses)
I personally can't agree that, it will make much more complex for function callers to construct a char[] array, then the couple of lines you saved will be back.
And, a lot of codes need to adjust with new function.
| @@ -462,3 +462,16 @@ MatviewIsGeneralyUpToDate(Oid mvoid) | |||
| return ((auxform->datastatus == MV_DATA_STATUS_UP_TO_DATE) || | |||
| (auxform->datastatus == MV_DATA_STATUS_UP_REORGANIZED)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
line150: namestrcpy(&mvname, get_rel_name(mvoid));
mvname without schema, maybe same mvname cause confused.
There was a problem hiding this comment.
Good catch.
The mvname should be with a schema prefix, this is for debug purpose during dev, maybe it could be removed, should be another topic.
If a table is vacuum or clutered, we should not avoid REFRESH for mvs have it. Else, if it's a partition or partitioned now and later, we could not use it for Append Agg. Authored-by: Zhang Mingli [email protected]
avamingli
force-pushed
the
fix_refresh_fast_path
branch
from
7baf081
to
5f03ab1
Compare
If a table is vacuum or clutered, we should not avoid REFRESH for mvs have it.
Else, if it's a partition or partitioned now and later, we could not use it for Append Agg.
Authored-by: Zhang Mingli [email protected]
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
[skip ci]to your PR title. Only use when necessary!