Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: update the name and information in files #731

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Nov 26, 2024

Fixes #ISSUE_Number

What does this PR do?

This PR includes four commits, which are used to rename the old project name to "Apache Cloudberry" and update the contact information. See the commit messages for details. These four commits contain so many changes, so let be patient for the review.

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

⚠️ To skip CI: Add [skip ci] to your PR title. Only use when necessary! ⚠️


In this PR, including the following changes:

* Rename the project name from "Cloudberry Database" to "Apache
  Cloudberry"
* Update the website url to "cloudberry.apache.org"
* Update the contact email from "[email protected]" to
  "[email protected]" mailing list
Rename the Cloudberry Database to Apache Cloudberry to address the
lastest project name change.
Rename the old name "Cloudberry Database" to "Apache Cloudberry" in the
directory doc/src/sgml/ref/*.sgml.
Rename the old name "Cloudberry Database" to "Apache Cloudberry" in
those following dir files:

* gpAux/*
* gpMgmt/*
* gpcontrib/*
* src/backend/*
* src/bin/*
* src/include/*
* src/pl/*
* src/nls-global.mk
* src/interfaces/*
* src/test/*
* src/fe_utils/option_utils.c
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated by autoconf 2.69.

@edespino
Copy link
Contributor

@tuhaihe How were these changes tested?

NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 's1' as the Cloudberry Database data distribution key for this table.
NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 's1' as the Apache Cloudberry data distribution key for this table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't change the message from code (*.c, python, bin and etc) files, this will introduce many file diffs which are pointless.
And the worse is, any databases like our commercial ones or tools based on CBDB would fail on CI due to that and have to fix them.
Rename the DOC part is enough. Cloudberry Database doesn't have conflict with Apache Cloudberry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't change the message from code (*.c, python, bin and etc) files, this will introduce many file diffs which are pointless. And the worse is, any databases like our commercial ones or tools based on CBDB would fail on CI due to that and have to fix them. Rename the DOC part is enough. Cloudberry Database doesn't have conflict with Apache Cloudberry

I tend to agree with @avamingli . However, there are several important user facing changes which would be appropriate to make. Like that in configure.ac which go into version(). There are also user facing help content we should consider making.

This is not an easy task but it has to be performed on some level.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @edespino @avamingli

Copy link
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename only the DOC part.

Copy link
Contributor

@edespino edespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See attatched file: there are many matches for CloudberryDB.
cloudberrydb-search.txt

See attached file: there are many matches for "Cloudberry" by itself
cloudberry-search.txt

There is also two test failures which might be related to this PR:

  • gpcopy_encoding
  • dispatch_encoding
  • qp_misc_rio_join_small

I can collaborate with you on running a wider test schedule list prior to committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants