Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional test suites. [skip-ci] #734

Closed
wants to merge 1 commit into from

Conversation

edespino
Copy link
Contributor

@edespino edespino commented Nov 27, 2024

Enabled the following suites:

  • ic-singlenode_isolation
  • ic-singlenode_isolation2
  • ic-resgroup-v2

Add step to display the contents of regression.diffs (if it exists)

Refactor check-skip job to handle PR-specific skip logic

  • Updated GitHub Actions check-skip job:
    • Modified logic to ensure skip behavior applies only to pull requests.
    • Enhanced message parsing to include both PR titles and bodies.
    • Ignored skip flags in direct pushes to main, ensuring full builds.
    • Incorporated proper escaping of input data to prevent command injection.

This update improves the reliability and security of the check-skip workflow, aligning it with project requirements to trigger full builds for direct pushes while respecting skip flags in PRs.

Enhance GitHub Actions workflow with ignored test support

  • Updated build-cloudberry.yml:

    • Added parsing and reporting of ignored tests in the test job.
    • Displayed names of ignored tests in test summaries.
    • Included regression diffs display to aid debugging of test failures.
    • Ensured consistent handling of failed and ignored tests across jobs.
  • Updated workflow header:

    • Documented ignored test handling in the test matrix.
    • Highlighted regression diffs display as a debugging feature.
    • Clarified reporting of failed and ignored tests in the workflow overview.

These changes improve the visibility and debugging of test results, ensuring ignored tests are appropriately tracked and reported without impacting the build status.

Enabled the following suites:

- `ic-expandshrink`
- `ic-singlenode_isolation`
- `ic-singlenode_isolation2`
- `ic-resgroup-v2`

Add step to display the contents of regression.diffs (if it exists)

Refactor check-skip job to handle PR-specific skip logic

- Updated GitHub Actions check-skip job:
  - Modified logic to ensure skip behavior applies only to pull requests.
  - Enhanced message parsing to include both PR titles and bodies.
  - Ignored skip flags in direct pushes to main, ensuring full builds.
  - Incorporated proper escaping of input data to prevent command injection.

This update improves the reliability and security of the check-skip
workflow, aligning it with project requirements to trigger full builds
for direct pushes while respecting skip flags in PRs.

Enhance GitHub Actions workflow with ignored test support

- Updated `build-cloudberry.yml`:
  - Added parsing and reporting of ignored tests in the `test` job.
  - Displayed names of ignored tests in test summaries.
  - Included regression diffs display to aid debugging of test failures.
  - Ensured consistent handling of failed and ignored tests across jobs.

- Updated workflow header:
  - Documented ignored test handling in the test matrix.
  - Highlighted regression diffs display as a debugging feature.
  - Clarified reporting of failed and ignored tests in the workflow overview.

These changes improve the visibility and debugging of test results,
ensuring ignored tests are appropriately tracked and reported without
impacting the build status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant