Fix autocomplete of migrateSystemVm #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the autocomplete of the
storageidparameter on themigrateSystemVmAPI is returning system VMs IDs instead of the expected storage IDs, as shown below. This bug also sets the CloudMonkey autocomplete cache for others APIs, such asmigrateVirtualMachine.This PR corrects this behavior by adding a verification so that the
autocompleteAPIstruct only changes itsNamemember tolistSystemVmswhen it's defined tolistVirtualMachines, thus not calling thelistSystemVmsAPI to autocomplete thestorageidparameter.Types of changes
Feature/Enhancement Scale
How Has This Been Tested?
On CloudMonkey the autocomplete of all parameters in
migrateSystemVmwas called, and verified to be the correct answer, as shown below.