Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Aug 8, 2025

Adds a Github action to build binaries for easier testing of PRs. A comment will be added in the PR.
Workflow runs on pull_request_target and has two jobs - build, comment.
comment job needs issues:write permission due to which the workflow can run only when it is present on main.
build job only has read permission to prevent insecure permissions

Tested here: shwstppr#3

Adds a Github action to build binary for Linux x86-64 for easier testing
of PRs. A comment will be added in the PR.

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 8, 2025

Had to recreate #170 as I force pushed builder branch after closing the PR

@shwstppr shwstppr marked this pull request as ready for review August 8, 2025 09:15
@shwstppr shwstppr added this to the 6.5.0 milestone Aug 8, 2025
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland
Copy link
Contributor

tested on your private-#3 great!

@shwstppr shwstppr merged commit 547b8a3 into apache:main Aug 8, 2025
2 checks passed
shwstppr added a commit to shwstppr/cloudstack-cloudmonkey that referenced this pull request Aug 13, 2025
Adds a Github action to build binaries for easier testing of PRs. A comment will be added in the PR.
Workflow runs on `pull_request_target` and has two jobs - build, comment.
`comment` job needs issues:write permission due to which the workflow can run only when it is present on main.
`build` job only has read permission to prevent insecure permissions

Tested here: #3

Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants