Validate the direct downloaded template file format (QCOW2) if the template file exists

[sureshanaparti]

Description

This PR validates the direct downloaded template file format (QCOW2) if the template file exists, otherwise skips validation & logs it.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.99%. Comparing base (c5afee2) to head (75eaa5b).

Files with missing lines	Patch %	Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10332      +/-   ##
============================================
- Coverage     16.00%   15.99%   -0.01%     
- Complexity    13062    13064       +2     
============================================
  Files          5644     5644              
  Lines        494915   494920       +5     
  Branches      59960    59962       +2     
============================================
- Hits          79187    79185       -2     
- Misses       406891   406897       +6     
- Partials       8837     8838       +1     

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.83% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12356

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12322)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59569 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12322-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.29	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.37	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.37	test_ipv4_routing.py
test_06_purge_expunged_vm_background_task	Failure	397.35	test_purge_expunged_vms.py
test_12_start_vm_multiple_volumes_allocated	Error	15.10	test_vm_life_cycle.py

[rohityadavcloud]

LGTM

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12339)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12339-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.29	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.35	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.36	test_ipv4_routing.py
test_06_purge_expunged_vm_background_task	Failure	382.78	test_purge_expunged_vms.py
test_12_start_vm_multiple_volumes_allocated	Error	14.88	test_vm_life_cycle.py

[DaanHoogland]

[SF] Trillian test result (tid-12339) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57382 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12339-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.29 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.35 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.36 test_ipv4_routing.py
test_06_purge_expunged_vm_background_task Failure 382.78 test_purge_expunged_vms.py
test_12_start_vm_multiple_volumes_allocated Error 14.88 test_vm_life_cycle.py

These errors seem consistent. I'm not sure wht the state of 4.20 is right now, though

[weizhouapache]

[SF] Trillian test result (tid-12339) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57382 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12339-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.29 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.35 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.36 test_ipv4_routing.py
test_06_purge_expunged_vm_background_task Failure 382.78 test_purge_expunged_vms.py
test_12_start_vm_multiple_volumes_allocated Error 14.88 test_vm_life_cycle.py

These errors seem consistent. I'm not sure wht the state of 4.20 is right now, though

#10252

[kiranchavala]

@blueorangutan package

[blueorangutan]

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12398