kvm: consider Debian same as Ubuntu #10917

weizhouapache · 2025-05-26T07:47:15Z

Description

This PR fixes the issue that UEFI is always false for debian hosts.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-05-26T07:47:44Z

@blueorangutan package

blueorangutan · 2025-05-26T07:50:07Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm

Pearl1594

clgtm

codecov · 2025-05-26T08:37:58Z

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.13%. Comparing base (f2a6a2f) to head (92b6f50).

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	6 Missing ⚠️
...m/resource/wrapper/LibvirtReadyCommandWrapper.java	33.33%	0 Missing and 2 partials ⚠️
...per/LibvirtCheckConvertInstanceCommandWrapper.java	0.00%	0 Missing and 1 partial ⚠️
.../wrapper/LibvirtConvertInstanceCommandWrapper.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10917      +/-   ##
============================================
- Coverage     16.13%   16.13%   -0.01%     
- Complexity    13239    13240       +1     
============================================
  Files          5656     5656              
  Lines        497622   497623       +1     
  Branches      60339    60341       +2     
============================================
- Hits          80302    80299       -3     
- Misses       408370   408372       +2     
- Partials       8950     8952       +2

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`16.98% <9.09%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-05-26T08:50:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13511

DaanHoogland · 2025-05-26T10:17:25Z

@blueorangutan help

blueorangutan · 2025-05-26T10:18:04Z

@DaanHoogland [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xenserver-84', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82', 'xcpng83']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87', 'rosi-shapeblue']

DaanHoogland · 2025-05-26T10:21:03Z

@blueorangutan test debian12 kvm-debian12

blueorangutan · 2025-05-26T10:22:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

blueorangutan · 2025-05-27T02:38:54Z

[SF] Trillian test result (tid-13401)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 56514 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13401-kvm-debian12.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_background_powerstate_sync	`Failure`	22.01	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	36.63	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	18.99	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	19.96	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	20.01	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	19.98	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	20.04	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	19.00	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Failure`	176.93	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	7.57	test_outofbandmanagement.py
test_hostha_kvm_host_degraded	`Error`	9.74	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	10.67	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	12.90	test_hostha_kvm.py

blueorangutan · 2025-05-27T23:31:11Z

[SF] Trillian test result (tid-13407)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 59351 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13407-kvm-debian12.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_background_powerstate_sync	`Failure`	22.02	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	37.88	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	20.09	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	20.06	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	19.01	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	19.00	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	20.07	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	20.03	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Failure`	178.26	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	7.52	test_outofbandmanagement.py
test_hostha_kvm_host_degraded	`Error`	13.12	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	12.18	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	12.23	test_hostha_kvm.py

sureshanaparti · 2025-06-05T08:50:49Z

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

        Map<String, String> versionString = getVersionStrings();
        String hostKey = "Host.OS";
        if (MapUtils.isEmpty(versionString) || !versionString.containsKey(hostKey) || versionString.get(hostKey) == null) {
            return false;
        }
-        return versionString.get(hostKey).equalsIgnoreCase("ubuntu");
+        return versionString.get(hostKey).equalsIgnoreCase("ubuntu")
+                || versionString.get(hostKey).startsWith("Debian");


Suggested change

|| versionString.get(hostKey).startsWith("Debian");

|| versionString.get(hostKey).toLowerCase().startsWith("debian");

kvm: consider Debian same as Ubuntu

92b6f50

boring-cyborg bot added the component:kvm label May 26, 2025

weizhouapache added this to the 4.20.1 milestone May 26, 2025

weizhouapache requested review from DaanHoogland and Pearl1594 May 26, 2025 07:47

DaanHoogland approved these changes May 26, 2025

View reviewed changes

Pearl1594 approved these changes May 26, 2025

View reviewed changes

rohityadavcloud approved these changes May 27, 2025

View reviewed changes

weizhouapache marked this pull request as ready for review May 27, 2025 06:51

Pearl1594 modified the milestones: 4.20.1, 4.20.2 Jun 3, 2025

sureshanaparti reviewed Jun 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

kvm: consider Debian same as Ubuntu #10917

kvm: consider Debian same as Ubuntu #10917

Uh oh!

weizhouapache commented May 26, 2025

Uh oh!

weizhouapache commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland left a comment

Uh oh!

Pearl1594 left a comment

Uh oh!

codecov bot commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

blueorangutan commented May 27, 2025

Uh oh!

blueorangutan commented May 27, 2025

Uh oh!

sureshanaparti Jun 5, 2025

Uh oh!

Uh oh!

	\|\| versionString.get(hostKey).startsWith("Debian");
	\|\| versionString.get(hostKey).toLowerCase().startsWith("debian");

kvm: consider Debian same as Ubuntu #10917

Are you sure you want to change the base?

kvm: consider Debian same as Ubuntu #10917

Uh oh!

Conversation

weizhouapache commented May 26, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 26, 2025

Codecov Report

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

DaanHoogland commented May 26, 2025

Uh oh!

blueorangutan commented May 26, 2025

Uh oh!

blueorangutan commented May 27, 2025

Uh oh!

blueorangutan commented May 27, 2025

Uh oh!

sureshanaparti Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!