Skip to content

npe guard for get host info on vmware #11054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: 4.19
Choose a base branch
from
Draft

npe guard for get host info on vmware #11054

wants to merge 4 commits into from
+6 −1

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR

Fixes: #10930

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland DaanHoogland changed the base branch from main to 4.19 June 18, 2025 17:35
weizhouapache
weizhouapache reviewed Jun 18, 2025
View reviewed changes
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java Outdated
if (aboutInfo == null) {
String msg = "no type info about host known"
s_logger.error(msg)
throw new Exception(msg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be defaulted to VmwareHostType.ESXi ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it mean if the host does not have this info? Is it in a valid state then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never face this issue before, but I know some users have faced the issue.

If we throw an Exception with message, instead of NPE, I think it does not help, as user will still get an exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but at least it will be clear they have an ill-configured host.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, I do not know what is misconfigured and any other issues caused by the misconfiguration.
I think we could consider the host as an ESXi host if the about info is not found.

anyone uses ESX host or other type of host ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, if y’all insist ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get more opinions

@nvazquez @harikrishna-patnala @sureshanaparti @shwstppr @rohityadavcloud
what's your opinion on it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I meant @weizhouapache , is your argument makes sense, I yield. Please see my changed code fragment at #11054 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, assuming ESXi seems to be a good option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@codecov Codecov
Copy link

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (cbd2b5a) to head (0524523).

Files with missing lines Patch % Lines
...in/java/com/cloud/hypervisor/vmware/mo/HostMO.java 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11054      +/-   ##
============================================
- Coverage     15.17%   15.17%   -0.01%     
+ Complexity    11363    11357       -6     
============================================
  Files          5416     5416              
  Lines        475911   475915       +4     
  Branches      58096    58097       +1     
============================================
- Hits          72241    72229      -12     
- Misses       395584   395602      +18     
+ Partials       8086     8084       -2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

harikrishna-patnala
harikrishna-patnala approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

weizhouapache
weizhouapache approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

thanks @DaanHoogland for the update

nvazquez
nvazquez approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - haven't faced this issue before but it I think it makes sense to assume ESXi host type

@apache apache deleted a comment from blueorangutan Jun 23, 2025
@apache apache deleted a comment from blueorangutan Jun 23, 2025
@apache apache deleted a comment from blueorangutan Jun 23, 2025
@apache apache deleted a comment from blueorangutan Jun 23, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@nvazquez nvazquez nvazquez approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:vmware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE when migrating VM in VMware and host not having 'config.product' property
5 participants
@DaanHoogland @blueorangutan @harikrishna-patnala @nvazquez @weizhouapache