ui: fix missing changes from #10814 #11060
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes from PR apache#10814 are missing in DeployVM and DeployVnf wizards causing warnings in teh browser console. Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11060 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
- Complexity 13967 13968 +1
============================================
Files 5743 5743
Lines 510468 510470 +2
Branches 62073 62074 +1
============================================
- Hits 84616 84615 -1
- Misses 416390 416392 +2
- Partials 9462 9463 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
merge forward errors become more frequesnt :( not sure I was the culprit but sorry anyway. |
|
verified in qa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some changes from PR #10814 are missing in DeployVM and DeployVnf wizards causing warnings in teh browser console.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
Launch button shows menu,
How Has This Been Tested?
How did you try to break this feature and the system with this change?