Skip to content

[Multi-Arch] Select Template Arch when creating template from volume #11068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.20
Choose a base branch
from

Conversation

nvazquez
Copy link
Contributor

Description

This PR allows selecting the template arch when creating a template from volume

Screenshot 2025-06-21 at 14 18 21

(the created template was always x86_64 and could be edited after its creation)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on Multi-Arch zone with 2 clusters each one with arch: x86_64 and aarch64
Create template from volume of an aarch 64 VM -> select aarch64 arch -> verify the created template arch

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (5790091) to head (340e953).

Files with missing lines Patch % Lines
...k/api/command/user/template/CreateTemplateCmd.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11068   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13274    13277    +3     
=========================================
  Files          5657     5657           
  Lines        497898   497902    +4     
  Branches      60374    60374           
=========================================
+ Hits          80441    80442    +1     
- Misses       408496   408498    +2     
- Partials       8961     8962    +1     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13865

…ate/CreateTemplateCmd.java

Co-authored-by: Abhishek Kumar <[email protected]>
@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13870

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants