-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Multi-Arch] Select Template Arch when creating template from volume #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11068 +/- ##
=========================================
Coverage 16.15% 16.15%
- Complexity 13274 13277 +3
=========================================
Files 5657 5657
Lines 497898 497902 +4
Branches 60374 60374
=========================================
+ Hits 80441 80442 +1
- Misses 408496 408498 +2
- Partials 8961 8962 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13865 |
api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
Outdated
Show resolved
Hide resolved
…ate/CreateTemplateCmd.java Co-authored-by: Abhishek Kumar <[email protected]>
@blueorangutan package |
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13870 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
This PR allows selecting the template arch when creating a template from volume
(the created template was always x86_64 and could be edited after its creation)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on Multi-Arch zone with 2 clusters each one with arch: x86_64 and aarch64
Create template from volume of an aarch 64 VM -> select aarch64 arch -> verify the created template arch
How did you try to break this feature and the system with this change?