server: fix vm deployment without networkid in a zone with shared networks

[weizhouapache]

Description

This PR fixes #11129

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.00%. Comparing base (06c80cd) to head (43479a1).
Report is 531 commits behind head on 4.20.

❗ There is a different number of reports uploaded between BASE (06c80cd) and HEAD (43479a1). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (06c80cd)	HEAD (43479a1)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #11242       +/-   ##
=============================================
- Coverage     15.18%    4.00%   -11.19%     
=============================================
  Files          5415      402     -5013     
  Lines        475888    32612   -443276     
  Branches      58094     5791    -52303     
=============================================
- Hits          72256     1305    -70951     
+ Misses       395546    31158   -364388     
+ Partials       8086      149     -7937     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.29%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14242

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14244

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14252

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13820)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53024 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11242-t13820-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sureshanaparti]

clgtm

[DaanHoogland]

clgtm

[DaanHoogland]

@weizhouapache , the issue is reported on 4.19.2, should we base this on the 4.19 branch?