-
Notifications
You must be signed in to change notification settings - Fork 1.2k
packaging: use latest cmk release link directly #11429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instead listing all GIthub releases first and finding the latest one use the direct link for the latest Github release. Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11429 +/- ##
=========================================
Coverage 17.35% 17.36%
- Complexity 15232 15233 +1
=========================================
Files 5885 5885
Lines 525618 525619 +1
Branches 64157 64157
=========================================
+ Hits 91225 91252 +27
+ Misses 424094 424072 -22
+ Partials 10299 10295 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@shwstppr (code lgtm) this will not work on arm base systems will it? Anything we can do about that? (new issue?) |
@DaanHoogland I think we'll have to bundle both x86-64 and arm64 binaries and during installation use the correct one. I'll try to check that separately. You may create a new issue if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@blueorangutan package |
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14618 |
Description
Instead listing all GIthub releases first and finding the latest one use the direct link for the latest Github release.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?