Skip to content

Conversation

@erikbocks
Copy link
Collaborator

Description

This PR enhances the SSVM details by adding its storage network IP to the API response and to the VM details tab in the GUI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

ssvm-details-tab

How Has This Been Tested?

After installing the packages with the changes to my local environment, I called the listSystemVMs API and validated that the IP was successfully added to the response. In addition to that, I accessed the SSVM details tab and validated that the IP was being displayed correctly.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (b99a030) to head (549d2dd).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...ache/cloudstack/api/response/SystemVmResponse.java 0.00% 6 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               main   #11979     +/-   ##
===========================================
  Coverage     17.56%   17.56%             
- Complexity    15500    15545     +45     
===========================================
  Files          5899     5909     +10     
  Lines        527793   529064   +1271     
  Branches      64479    64618    +139     
===========================================
+ Hits          92714    92948    +234     
- Misses       424653   425662   +1009     
- Partials      10426    10454     +28     
Flag Coverage Δ
uitests 3.58% <ø> (-0.02%) ⬇️
unittests 18.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

just a minor comment:
normally we use public/private/linklocal/management ip (no network in the serialized name)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying the storage network IP address for system VMs. The change exposes the storage network IP through the API response and makes it visible in the UI.

Key Changes:

  • Added storageNetworkIp field to the SystemVmResponse API response class
  • Modified ApiResponseHelper to populate the storage network IP when available
  • Updated UI configuration to display the new field in system VM details

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
api/src/main/java/org/apache/cloudstack/api/response/SystemVmResponse.java Added storageNetworkIp field with getter/setter methods
server/src/main/java/com/cloud/api/ApiResponseHelper.java Added logic to set storage network IP when traffic type is Storage
ui/src/config/section/infra/systemVms.js Added storagenetworkip to the details array for system VMs
ui/public/locales/en.json Added English translation for storage network IP label
ui/public/locales/pt_BR.json Added Portuguese (Brazil) translation for storage network IP label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mkriegs
Copy link

mkriegs commented Nov 4, 2025

If storage is ipv6? Not displayed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants