-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement SSVM storage network IP to API response and GUI details tab #11979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11979 +/- ##
===========================================
Coverage 17.56% 17.56%
- Complexity 15500 15545 +45
===========================================
Files 5899 5909 +10
Lines 527793 529064 +1271
Branches 64479 64618 +139
===========================================
+ Hits 92714 92948 +234
- Misses 424653 425662 +1009
- Partials 10426 10454 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm
just a minor comment:
normally we use public/private/linklocal/management ip (no network in the serialized name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for displaying the storage network IP address for system VMs. The change exposes the storage network IP through the API response and makes it visible in the UI.
Key Changes:
- Added
storageNetworkIpfield to theSystemVmResponseAPI response class - Modified
ApiResponseHelperto populate the storage network IP when available - Updated UI configuration to display the new field in system VM details
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/src/main/java/org/apache/cloudstack/api/response/SystemVmResponse.java | Added storageNetworkIp field with getter/setter methods |
| server/src/main/java/com/cloud/api/ApiResponseHelper.java | Added logic to set storage network IP when traffic type is Storage |
| ui/src/config/section/infra/systemVms.js | Added storagenetworkip to the details array for system VMs |
| ui/public/locales/en.json | Added English translation for storage network IP label |
| ui/public/locales/pt_BR.json | Added Portuguese (Brazil) translation for storage network IP label |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
If storage is ipv6? Not displayed? |
Description
This PR enhances the SSVM details by adding its storage network IP to the API response and to the VM details tab in the GUI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
After installing the packages with the changes to my local environment, I called the
listSystemVMsAPI and validated that the IP was successfully added to the response. In addition to that, I accessed the SSVM details tab and validated that the IP was being displayed correctly.