Don't initialize an instance variable to its default value

apache · Oct 27, 2023 · dee9ac8 · dee9ac8
1 parent 9821c35
commit dee9ac8
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
@@ -290,7 +290,7 @@ private static boolean canConvertToInfoZipExtendedTimestamp(
 
     private long diskNumberStart;
 
-    private boolean lastModifiedDateSet = false;
+    private boolean lastModifiedDateSet;
 
     private long time = -1;
 

diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java b/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
@@ -188,10 +188,10 @@ protected static int countArgs(final String descriptor) {
 
 	private TempParamAnnotation tempMethodRVPA;
 	private TempParamAnnotation tempMethodRIPA;
-	private boolean anySyntheticClasses = false;
-	private boolean anySyntheticFields = false;
+	private boolean anySyntheticClasses;
+	private boolean anySyntheticFields;
 
-	private boolean anySyntheticMethods = false;
+	private boolean anySyntheticMethods;
 	private final Segment segment;
 
 	private final Map<CPClass, Set<CPClass>> classReferencesInnerClass = new HashMap<>();

diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java
@@ -80,11 +80,11 @@ protected Attribute read(final ClassReader cr, final int off, final int len, fin
             return null;
         }
     }
-    private boolean contextClass = false;
+    private boolean contextClass;
 
-    private boolean contextMethod = false;
-    private boolean contextField = false;
-    private boolean contextCode = false;
+    private boolean contextMethod;
+    private boolean contextField;
+    private boolean contextCode;
     private final String layout;
     private byte[] contents;
     private int codeOff;

diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
@@ -295,7 +295,7 @@ public class Reference extends LayoutElement {
 
         private List<ConstantPoolEntry> band;
 
-        private boolean nullsAllowed = false;
+        private boolean nullsAllowed;
 
         public Reference(final String tag) {
             this.tag = tag;

diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java b/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java
@@ -43,7 +43,7 @@ public class PackingUtils {
 
     private static final class PackingLogger extends Logger {
 
-        private boolean verbose = false;
+        private boolean verbose;
 
         protected PackingLogger(final String name, final String resourceBundleName) {
             super(name, resourceBundleName);

diff --git a/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java b/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java
@@ -45,7 +45,7 @@
 public class MultiReadOnlySeekableByteChannelTest {
 
     private static final class ThrowingSeekableByteChannel implements SeekableByteChannel {
-        private boolean closed = false;
+        private boolean closed;
         @Override
         public void close() throws IOException {
             closed = true;