Skip to content

Conversation

MichielDx
Copy link

@garydgregory I get following error while clean installing, but I'm not familiar with japicmp:
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp (default) on project commons-configuration2: There is at least one incompatibility: org.apache.commons.configuration2.web.ServletConfiguration.ServletConfiguration(javax.servlet.ServletConfig):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletConfiguration.ServletConfiguration(javax.servlet.Servlet):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletConfiguration.config:FIELD_TYPE_CHANGED,org.apache.commons.configuration2.web.ServletContextConfiguration.ServletContextConfiguration(javax.servlet.Servlet):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletContextConfiguration.ServletContextConfiguration(javax.servlet.ServletContext):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletContextConfiguration.context:FIELD_TYPE_CHANGED,org.apache.commons.configuration2.web.ServletFilterConfiguration.ServletFilterConfiguration(javax.servlet.FilterConfig):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletFilterConfiguration.config:FIELD_TYPE_CHANGED,org.apache.commons.configuration2.web.ServletRequestConfiguration.ServletRequestConfiguration(javax.servlet.ServletRequest):CONSTRUCTOR_REMOVED,org.apache.commons.configuration2.web.ServletRequestConfiguration.request:FIELD_TYPE_CHANGED -> [Help 1]

@garydgregory
Copy link
Member

Then you've broken binary compatibility as the error message says.

Please see https://garygregory.wordpress.com/2020/06/14/how-we-handle-binary-compatibility-at-apache-commons/

@MichielDx
Copy link
Author

@garydgregory I changed it to configuration3, but now I get following error:
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp (default) on project commons-configuration3: Execution default of goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp failed: Could not load 'org.apache.hadoop.fs.DelegateToFileSystem': org.apache.hadoop.fs.DelegateToFileSystem. Please make sure that all libraries have been added to the classpath (CLASSPATH=:/home/michiel/.m2/repository/com/squareup/okio/okio/1.6.0/okio-1.6.0.jar:/home/michiel/.m2/repository/org/yaml/snakeyaml/2.2/snakeyaml-2.2.jar:/home/michiel/.m2/repository/org/apache/logging/log4j/log4j-core/2.23.1/log4j-core-2.23.1.jar:/home/michiel/.m2/repository/org/springframework/spring-beans/5.3.32/spring-beans-5.3.32.jar:/home/michiel/.m2/repository/org/apache/hadoop/hadoop-hdfs-client/3.3.1/hadoop-hdfs-client-3.3.1.jar:/home/michiel/.m2/repository/commons-logging/commons-logging/1.3.0/commons-logging-1.3.0.jar:/home/michiel/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.17.0/jackson-annotations-2.17.0.jar:/home/michiel/.m2/repository/xml-resolver/xml-resolver/1.2/xml-resolver-1.2.jar:/home/michiel/.m2/repository/commons-codec/commons-codec/1.16.1/commons-codec-1.16.1.jar:/home/michiel/.m2/repository/com/squareup/okhttp/okhttp/2.7.5/okhttp-2.7.5.jar:/home/michiel/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar:/home/michiel/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.17.0/jackson-core-2.17.0.jar:/home/michiel/.m2/repository/org/apache/commons/commons-lang3/3.14.0/commons-lang3-3.14.0.jar:/home/michiel/.m2/repository/org/springframework/spring-core/5.3.32/spring-core-5.3.32.jar:/home/michiel/.m2/repository/commons-jxpath/commons-jxpath/1.3/commons-jxpath-1.3.jar:/home/michiel/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.17.0/jackson-databind-2.17.0.jar:/home/michiel/.m2/repository/net/bytebuddy/byte-buddy/1.14.9/byte-buddy-1.14.9.jar:/home/michiel/.m2/repository/jakarta/servlet/jakarta.servlet-api/6.0.0/jakarta.servlet-api-6.0.0.jar:/home/michiel/.m2/repository/org/apache/commons/commons-jexl/2.1.1/commons-jexl-2.1.1.jar:/home/michiel/IdeaProjects/commons-configuration-michieldx/target/commons-configuration3-3.0.0-SNAPSHOT.jar:/home/michiel/.m2/repository/org/apache/commons/commons-text/1.11.0/commons-text-1.11.0.jar:/home/michiel/.m2/repository/commons-beanutils/commons-beanutils/1.9.4/commons-beanutils-1.9.4.jar:/home/michiel/.m2/repository/org/apache/logging/log4j/log4j-1.2-api/2.23.1/log4j-1.2-api-2.23.1.jar:/home/michiel/.m2/repository/org/apache/commons/commons-vfs2/2.9.0/commons-vfs2-2.9.0.jar:/home/michiel/.m2/repository/org/apache/logging/log4j/log4j-api/2.23.1/log4j-api-2.23.1.jar:) or try the option '--ignore-missing-classes'. -> [Help 1]

@garydgregory
Copy link
Member

@MichielDx
A (broken) PR with 510 changed files is not something reviewable or reasonable. Changing package names for a major version change is a task best left for someone on the Commons side to do. A Jira ticket with the motivation and what it means for users and how users would update is a start.

@MichielDx
Copy link
Author

@garydgregory Reverted the rename, but still getting the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants