Sort Checkstyle modules

apache · Feb 28, 2025 · 6ddfa79 · 6ddfa79
1 parent 38e0fd4
commit 6ddfa79
Showing 1 changed file with 27 additions and 33 deletions.
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
@@ -22,12 +22,15 @@ limitations under the License.
 <!-- Commons Net customization of default Checkstyle behavior -->
 <module name="Checker">
   <property name="localeLanguage" value="en"/>
+  <module name="FileTabCharacter">
+    <property name="fileExtensions" value="java,xml"/>
+  </module>
   <module name="JavadocPackage">
     <!-- setting allowLegacy means it will check for package.html instead of just package-info.java -->
     <property name="allowLegacy" value="true"/>
   </module>
-  <module name="FileTabCharacter">
-    <property name="fileExtensions" value="java,xml"/>
+  <module name="LineLength">
+    <property name="max" value="160"/>
   </module>
   <!-- Checks for white space at the end of the line -->
   <!-- See http://checkstyle.sourceforge.net/config_regexp.html -->
@@ -42,32 +45,40 @@ limitations under the License.
     <property name="message" value="Deprecated @author tag" />
     <property name="fileExtensions" value="java" />
   </module>
-  <module name="LineLength">
-    <property name="max" value="160"/>
+  <!-- @author tags are deprecated -->
+  <module name="RegexpSingleline">
+    <property name="format" value="^\s+\*\s+@author\s" />
+    <property name="message" value="Deprecated @author tag" />
+    <property name="fileExtensions" value="java" />
+    <property name="severity" value="warning" />
+  </module>
+  <module name="SuppressionFilter">
+    <!-- config_loc is used by Eclipse plugin -->
+    <property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
   </module>
   <module name="TreeWalker">
     <module name="AvoidStarImport">
       <property name="excludes" value="org.junit.Assert"/>
     </module>
-    <module name="RedundantImport"/>
-    <module name="UnusedImports"/>
-    <module name="NeedBraces"/>
-    <module name="ParenPad"/>
-    <!-- Modifier Checks                                    -->
-    <!-- See http://checkstyle.sf.net/config_modifiers.html -->
-    <module name="ModifierOrder"/>
-    <!--module name="RedundantModifier"/-->
-    <!-- Checks for blocks. You know, those {}'s         -->
-    <!-- See http://checkstyle.sf.net/config_blocks.html -->
-    <!--module name="AvoidNestedBlocks"/-->
     <module name="EmptyBlock">
       <property name="option" value="text"/>
     </module>
     <module name="EmptyCatchBlock"></module>
+    <module name="ImportOrder">
+      <property name="option" value="top"/>
+      <property name="groups" value="java,javax,org"/>
+      <property name="ordered" value="true"/>
+      <property name="separated" value="true"/>
+    </module>
     <module name="JavadocMethod">
       <property name="accessModifiers" value="public"/>
       <property name="allowMissingParamTags" value="true"/>
     </module>
+    <module name="ModifierOrder"/>
+    <module name="NeedBraces"/>
+    <module name="ParenPad"/>
+    <module name="RedundantImport"/>
+    <module name="UnusedImports"/>
     <module name="SuppressionCommentFilter"/>
     <!--
         Allow comment to suppress checkstyle for a single line
@@ -77,26 +88,9 @@ limitations under the License.
       <property name="commentFormat" value="CHECKSTYLE IGNORE (\w+)"/>
       <property name="checkFormat" value="$1"/>
     </module>
-    <module name="ImportOrder">
-      <property name="option" value="top"/>
-      <property name="groups" value="java,javax,org"/>
-      <property name="ordered" value="true"/>
-      <property name="separated" value="true"/>
-    </module>
+    <module name="TypecastParenPad" />
     <module name="WhitespaceAfter" />
     <module name="WhitespaceAround" />
-    <module name="TypecastParenPad" />
-  </module>
-  <module name="SuppressionFilter">
-    <!-- config_loc is used by Eclipse plugin -->
-    <property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
-  </module>
-  <!-- @author tags are deprecated -->
-  <module name="RegexpSingleline">
-    <property name="format" value="^\s+\*\s+@author\s" />
-    <property name="message" value="Deprecated @author tag" />
-    <property name="fileExtensions" value="java" />
-    <property name="severity" value="warning" />
   </module>
 </module>