-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulletproof TFTPServerPathTest #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but there might be something else that needs to be done in the new test, CI failing on ubuntu + Java 8
Error: Failures:
Error: TFTPServerPathTest.testWriteOnly:154 expected: <false> but was: <true>
Thank you!
Thank you @kinow for the fast response! |
@jkbkupczyk |
done |
TY @jkbkupczyk ! |
Thank you @garydgregory and @kinow for review! |
Hm, I think it's because files have the same name, I will create a patch that will address this issue. |
TY! |
I created patch #184 |
TFTPServer::getPort
method to return TFTPServer portThis PR tries to get rid of notoriously failing TFTPServerPathTest on Windows 8 on CI pipeline with the message
TFTPServerPathTest.testReadOnly:82 Couldn't clear output location, deleted= ==> expected: <false> but was: <true>
FYI
@garydgregory @kinow