Use a immutable 'characterList' to receive characters passing by with… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inRange and selectFrom to let method chaining is meaningful
```java
GENERATOR = new RandomStringGenerator.Builder()
.withinRange(CHAR_PAIRS)
.selectFrom(',', ';', ':', '?', '*', '#', '!')
.build();
```
|
@ijliym |
garydgregory
requested changes
Jun 3, 2022
| @@ -247,6 +247,7 @@ public String generate(final int minLengthInclusive, final int maxLengthInclusiv | |||
| * Some commonly used predicates are provided by the {@link CharacterPredicates} enum.</p> | |||
| * | |||
| * <p>This class is not thread safe.</p> | |||
| * | |||
There was a problem hiding this comment.
No need for extra whitespace here.
| @@ -328,7 +329,7 @@ public Builder withinRange(final int minimumCodePoint, final int maximumCodePoin | |||
| * Specifies the array of minimum and maximum char allowed in the | |||
| * generated string. | |||
| * </p> | |||
| * | |||
| * <p> | |||
| * For example: | |||
| * <pre> | |||
There was a problem hiding this comment.
If you open a p tag above, then close it before this pre tag.
| * @return The configured {@code RandomStringGenerator} | ||
| */ | ||
| @Override | ||
| public RandomStringGenerator build() { | ||
| return new RandomStringGenerator(minimumCodePoint, maximumCodePoint, inclusivePredicates, | ||
| random, characterList); | ||
| } | ||
|
|
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inRange and selectFrom to let method chaining is meaningful
I think, multiple calls
selectFrommethod to replace the previously stored Character is no use.