-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review create
default values and small rework
#1100
Open
ath0mas
wants to merge
7
commits into
apache:master
Choose a base branch
from
ath0mas:feature/create-defaults-ios
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage ? 74.88%
=========================================
Files ? 13
Lines ? 1724
Branches ? 0
=========================================
Hits ? 1291
Misses ? 433
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Apr 18, 2021
breautek
approved these changes
Apr 19, 2021
ath0mas
force-pushed
the
feature/create-defaults-ios
branch
from
November 6, 2023 22:54
6663d7b
to
5651b57
Compare
ath0mas
force-pushed
the
feature/create-defaults-ios
branch
from
November 6, 2023 22:59
5651b57
to
88d3d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Mixed default values for
create
between cli doc, cordova-android and cordova-ios.Description
Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:
io.cordova.helloCordova
Hello Cordova
See linked PRs: apache/cordova-cli#554, apache/cordova-android#1213
And
createProject
on how to init and deal with its parametersremove useless check on project_parent asfs.ensureDirSync
is used(see each commit for detail on my steps)
Testing
npm test
successChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)