(iOS) Avoid repetitive permission prompts

[jancabadaj]

Platforms affected

iOS

Motivation and Context

resolves #1166

Description

If the app uses WebRTC, the user is initially prompted for permission twice, and then prompted again each time the app is restarted.

The solution is inspired by react:
react-native-webview/react-native-webview#2257

Testing

I tested the changes in a project that is using WebRTC camera streaming.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[vbraun]

Works for me, for what its worth!

I would consider setting the default to "grant" because nobody wants the repeated permission request.

[jancabadaj]

I fixed merge issues and changed default to 'grant' as suggested

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (18a80d2) to head (b9d2a04).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   80.86%   80.84%   -0.03%     
==========================================
  Files          16       16              
  Lines        1840     1848       +8     
==========================================
+ Hits         1488     1494       +6     
- Misses        352      354       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dpogue]

Thanks for doing the work to implement this!

With the "grant by default" behaviour, does that mean things like 3rd party iframes on a page would automatically be able to initiate webcam and microphone access? If so, I don't think we can have it that permissive by default.

A reasonable middle ground would probably be the "grantIfSameHostElsePrompt" behaviour so that the app's same-origin content can access those APIs but any 3rd party origins would result in a prompt.

[jancabadaj]

Yes, that is correct. There is still an initial permission request, but once the app has permission, any site can access the webcam and microphone with "grant".

In our use case that is exactly what we need, since we are taking a photo from a website within iframe, but I agree that "grantIfSameHostElsePrompt" might be better as default. I will change it.

[erikramalho]

Do we have an estimated release date for version 8.0.0?

[dpogue]

Do we have an estimated release date for version 8.0.0?

@erikramalho No estimated release date because it's entirely dependent on volunteer time to investigate and address the remaining bugs and new features.

[erikramalho]

Thanks for the answer @dpogue. I'll ask my team to look and see if we can help with any remaining bugs and new features.