Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set CodeSigning Entitlements in Xcode Project at Target level #1438

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented May 28, 2024

Platforms affected

iOS

Motivation and Context

Closes GH-1135.

Description

Moved CODE_SIGN_ENTITLEMENTS from the xcconfig (which affects the entire project and all its targets) to the target settings of the application target within the Xcode project.

Testing

Confirmed manually that the Xcode project settings for the target have the expected values.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@dpogue dpogue added this to the 7.1.1 milestone May 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (2240ebc) to head (1cb893a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1438   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@expcapitaldev
Copy link

hi Cordova team, very important issue, waiting!

@erisu erisu merged commit 91f8a7f into apache:master Jul 11, 2024
10 checks passed
@dpogue dpogue deleted the codesign-entitlements branch August 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants