Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)!: access Context through webView.getContext() #201

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(android)!: access Context through webView.getContext() #201

merged 2 commits into from
May 15, 2024

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented May 14, 2024 •
edited
Loading

closes #62

@jcesarmobile jcesarmobile mentioned this pull request May 14, 2024
Merged
5 tasks
@jcesarmobile jcesarmobile changed the title CB-12623: (android) use the new context getter to access Context fix(android)!: access Context through webView.getContext() (CB-12623) May 14, 2024
@jcesarmobile jcesarmobile changed the title fix(android)!: access Context through webView.getContext() (CB-12623) fix(android)!: access Context through webView.getContext() May 14, 2024
erisu
erisu approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 8124857 into master May 15, 2024
7 of 19 checks passed
@erisu erisu deleted the pick branch May 15, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcesarmobile @erisu @dreifachstein