Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1008 - shutdown OmegaEdit when running yarn test on Windows #1138

Merged
merged 1 commit into from
Jan 2, 2025
Merged

#1008 - shutdown OmegaEdit when running yarn test on Windows #1138

merged 1 commit into from
Jan 2, 2025

Conversation

scholarsmate
Copy link
Contributor

Closes #1008.

@scholarsmate scholarsmate added bug Something isn't working testing Updates to test suite typescript labels Dec 4, 2024
@scholarsmate scholarsmate added this to the 1.4.1 milestone Dec 4, 2024
@scholarsmate scholarsmate self-assigned this Dec 4, 2024
@scholarsmate scholarsmate force-pushed the 1008/fix_OmegaEdit_shutdown_in_yarn_test branch from ae43478 to edda9ec Compare December 4, 2024 20:13
@scholarsmate scholarsmate force-pushed the 1008/fix_OmegaEdit_shutdown_in_yarn_test branch from edda9ec to 3cbc1b8 Compare December 10, 2024 14:06
@scholarsmate scholarsmate requested a review from arosien December 10, 2024 14:29
shanedell
shanedell approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@shanedell shanedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 👍

rthomas320
rthomas320 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@rthomas320 rthomas320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OmegaEdit server window closed properly while running yarn test.

@scholarsmate scholarsmate merged commit a8b5b44 into apache:main Jan 2, 2025
21 checks passed
@scholarsmate scholarsmate deleted the 1008/fix_OmegaEdit_shutdown_in_yarn_test branch January 2, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanedell shanedell shanedell approved these changes

@rthomas320 rthomas320 rthomas320 approved these changes

@stricklandrbls stricklandrbls Awaiting requested review from stricklandrbls

@arosien arosien Awaiting requested review from arosien

Assignees

@scholarsmate scholarsmate

Labels
bug Something isn't working testing Updates to test suite typescript
Projects
daffodil-vscode v1.4.1
Status: Done
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

OmegaEdit server fails to shutdown when running yarn test on Windows 10
3 participants
@scholarsmate @shanedell @rthomas320