Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment xpath/dpath validation #884

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

michael-hoke
Copy link
Collaborator

Closes #850

Adds fn:concat function with 2 arguments

Adds hard-coded/prebuilt variables:

  • dfdl:encoding
  • dfdl:byteOrder
  • dfdl:binaryFloatRep
  • dfdl:outputNewLine

Check the prefix of variables, and don't flag them if the prefix is valid. Note that this will also prevent the above variables from being flagged. Do we need to do anything else to differentiate?

@michael-hoke michael-hoke self-assigned this Nov 1, 2023
@michael-hoke michael-hoke added this to the 1.4.0 milestone Nov 1, 2023
@michael-hoke
Copy link
Collaborator Author

@mbeckerle Would you mind checking these changes with a couple of schemas? If you don't want to build the branch, I can get you a .vsix - just let me know.

Copy link
Collaborator

@NolanMatt NolanMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks completed

Copy link
Contributor

@scholarsmate scholarsmate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@shanedell shanedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Squash your commits and force push and this can merged in once CI passes

@michael-hoke michael-hoke force-pushed the 850-augment-xpath-validation branch from e474bcb to 969bf5e Compare November 13, 2023 18:47
Augment XPath validation:
  - Prebuilt dfdl variables
  - fn:concat with 2 arguments
  - Don't flag dfdl variables with a valid namespace
@michael-hoke michael-hoke force-pushed the 850-augment-xpath-validation branch from 969bf5e to bf994d0 Compare December 5, 2023 16:43
@scholarsmate scholarsmate merged commit 48d4580 into apache:main Dec 6, 2023
21 checks passed
@scholarsmate scholarsmate deleted the 850-augment-xpath-validation branch December 6, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Augment XPath Validation to be More Complete
4 participants