-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added development.md #900
Added development.md #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
You'll have to create this as a single patch and rebase on the current main before it will be mergable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Just rebase off of the Apache repo's main
branch and squash all commits except one. Then create a message you like and force push up to your branch.
4c1a395
to
9237482
Compare
3335938
to
c985a88
Compare
I just noticed this PR contains links to assets in github.com/ctc-oss, should those assets be moved to daffodil-vscode so everything is in this repo? |
Ah I see what you mean, I was curious how that worked with the PR and if it would move them over here, but I guess that's not how that works, I'll see about moving them over here |
Seems they may have to be added manually by someone with write access to that wiki file @shanedell |
Another option is to replace images with text where possible. For example, the image that shows the fork button could be replaced with the a link to https://github.com/apache/daffodil-vscode/fork. Making things a user can copy paste or click is probably a bit easier than telling people to find a button on another page. Avoiding images where possible is also friendlier to people with visual impairments. |
closes #853
Added development.md