Skip to content

Conversation

kazantsev-maksim
Copy link
Contributor

@kazantsev-maksim kazantsev-maksim commented Sep 27, 2025

Which issue does this PR close?

Part of: #2443

Rationale for this change

Part of: #2443

What changes are included in this PR?

  1. QueryPlanSerde.scala: sha1 matching case has been added
  2. hash.scala: comet expression serde for sha1 has been added
  3. jna_api.rs: register UDFs from datafusion-spark crate has been added

How are these changes tested?

A new UT has been added.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kazantsev-maksim starting CI

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.41%. Comparing base (f09f8af) to head (46325a4).
⚠️ Report is 561 commits behind head on main.

Files with missing lines Patch % Lines
...k/src/main/scala/org/apache/comet/serde/hash.scala 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2471      +/-   ##
============================================
+ Coverage     56.12%   58.41%   +2.29%     
- Complexity      976     1436     +460     
============================================
  Files           119      146      +27     
  Lines         11743    13516    +1773     
  Branches       2251     2351     +100     
============================================
+ Hits           6591     7896    +1305     
- Misses         4012     4390     +378     
- Partials       1140     1230      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants