feat: support multiple value for pivot #1970
Open
+44
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Aug 2, 2025
| @@ -1336,7 +1336,7 @@ pub enum TableFactor { | |||
| Pivot { | |||
| table: Box<TableFactor>, | |||
| aggregate_functions: Vec<ExprWithAlias>, // Function expression | |||
| value_column: Vec<Ident>, | |||
| value_column: Vec<Expr>, // Expr is a identifier or a compound identifier | |||
There was a problem hiding this comment.
Suggested change
| value_column: Vec<Expr>, // Expr is a identifier or a compound identifier | |
| value_column: Vec<Expr>, |
Comment on lines
+10933
to
+10936
| assert_eq!( | ||
| verified_stmt(sql_with_multiple_value_column).to_string(), | ||
| sql_with_multiple_value_column | ||
| ); |
There was a problem hiding this comment.
hmm this assertion is probably not needed, I think verified_stmt already does the same assertion
Comment on lines
+13843
to
+13849
| let value_column = if self.peek_token_ref().token == Token::LParen { | ||
| self.parse_parenthesized_compound_identifier_list(Mandatory, false)? | ||
| } else { | ||
| vec![Expr::CompoundIdentifier( | ||
| self.parse_period_separated(|p| p.parse_identifier())?, | ||
| )] | ||
| }; |
There was a problem hiding this comment.
similar to unpivot can we call parse_expr directly here?
There was a problem hiding this comment.
no, we cannot do it here. (name, age) IN (('John', 30) AS c1, ('Mike', 40) AS c2) will be parsed as an expr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-pivot.html
currently this sql is not supported.