fix clippy lint error

apache · Mar 22, 2024 · 2bb149e · 2bb149e
1 parent 06500ef
commit 2bb149e
Showing 1 changed file with 21 additions and 23 deletions.
diff --git a/datafusion/sql/src/statement.rs b/datafusion/sql/src/statement.rs
@@ -866,33 +866,31 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
             FileType::from_str(&file_type).map_err(|_| {
                 DataFusionError::Configuration(format!("Unknown FileType {}", file_type))
             })?
+        } else if let Some(format) = options.remove("format") {
+            // try to infer file format from the "format" key in options
+            FileType::from_str(&format)
+                .map_err(|e| DataFusionError::Configuration(format!("{}", e)))?
         } else {
-            if let Some(format) = options.remove("format") {
-                // try to infer file format from the "format" key in options
-                FileType::from_str(&format)
-                    .map_err(|e| DataFusionError::Configuration(format!("{}", e)))?
-            } else {
-                let e = || {
-                    DataFusionError::Configuration(
+            let e = || {
+                DataFusionError::Configuration(
                     "Format not explicitly set and unable to get file extension! Use STORED AS to define file format."
                         .to_string(),
                 )
-                };
-                // try to infer file format from file extension
-                let extension: &str = &Path::new(&statement.target)
-                    .extension()
-                    .ok_or_else(e)?
-                    .to_str()
-                    .ok_or_else(e)?
-                    .to_lowercase();
-
-                FileType::from_str(extension).map_err(|e| {
-                    DataFusionError::Configuration(format!(
-                        "{}. Use STORED AS to define file format.",
-                        e
-                    ))
-                })?
-            }
+            };
+            // try to infer file format from file extension
+            let extension: &str = &Path::new(&statement.target)
+                .extension()
+                .ok_or_else(e)?
+                .to_str()
+                .ok_or_else(e)?
+                .to_lowercase();
+
+            FileType::from_str(extension).map_err(|e| {
+                DataFusionError::Configuration(format!(
+                    "{}. Use STORED AS to define file format.",
+                    e
+                ))
+            })?
         };
 
         let partition_by = statement