Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
UBarney committed Dec 22, 2024
1 parent 5803583 commit 9a11088
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions datafusion/functions-table/src/generate_series.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,23 @@ use parking_lot::RwLock;
use std::fmt;
use std::sync::Arc;

/// Indicates the arguments used for generating a series.
#[derive(Debug, Clone)]
enum GenSeriesArgs {
/// ContainsNull signifies that at least one argument(start, end, step) was null, thus no series will be generated.
ContainsNull,
/// AllNotNullArgs holds the start, end, and step values for generating the series when all arguments are not null.
AllNotNullArgs { start: i64, end: i64, step: i64 },
}

/// Table that generates a series of integers from `start`(inclusive) to `end`(inclusive)
/// Table that generates a series of integers from `start`(inclusive) to `end`(inclusive), incrementing by step
#[derive(Debug, Clone)]
struct GenerateSeriesTable {
schema: SchemaRef,
args: GenSeriesArgs,
}

/// Table state that generates a series of integers from `start`(inclusive) to `end`(inclusive)
/// Table state that generates a series of integers from `start`(inclusive) to `end`(inclusive), incrementing by step
#[derive(Debug, Clone)]
struct GenerateSeriesState {
schema: SchemaRef,
Expand Down

0 comments on commit 9a11088

Please sign in to comment.