Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDAF refactor: Add PhysicalExpr trait dependency on datafusion-expr and remove logical expressions requirement for creating physical aggregate expression #11845

Merged
merged 30 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f9c2087
init draft
jayzhan211 Aug 6, 2024
51350d4
production ready
jayzhan211 Aug 6, 2024
1bf175b
cleanup
jayzhan211 Aug 6, 2024
d9c204f
Merge branch 'main' of https://github.com/apache/datafusion into udaf…
jayzhan211 Aug 6, 2024
bf394cc
fix merge conflict
jayzhan211 Aug 6, 2024
a2e4cba
mv accumulator out
jayzhan211 Aug 6, 2024
4a63405
fix doc
jayzhan211 Aug 6, 2024
c4f485c
Merge branch 'main' of https://github.com/apache/datafusion into udaf…
jayzhan211 Aug 6, 2024
f218184
rename
jayzhan211 Aug 6, 2024
c26e4d5
fix test
jayzhan211 Aug 6, 2024
366f2bf
fix test
jayzhan211 Aug 6, 2024
a90b28e
doc
jayzhan211 Aug 6, 2024
93a514e
fix doc and cleanup
jayzhan211 Aug 7, 2024
3841736
fix doc
jayzhan211 Aug 7, 2024
5ef93e1
clippy + doc
jayzhan211 Aug 7, 2024
4b22995
cleanup
jayzhan211 Aug 7, 2024
e7f0edc
cleanup
jayzhan211 Aug 7, 2024
cfd1734
rename exprs
jayzhan211 Aug 7, 2024
061d4dd
rm create_aggregate_expr_with_dfschema
jayzhan211 Aug 7, 2024
c8846a6
revert change in calc_requirements
jayzhan211 Aug 7, 2024
87b5d42
fmt
jayzhan211 Aug 7, 2024
b1a15db
doc and cleanup
jayzhan211 Aug 8, 2024
8fc4f7f
Merge branch 'main' of https://github.com/apache/datafusion into udaf…
jayzhan211 Aug 8, 2024
b76b8f0
rm dfschema
jayzhan211 Aug 8, 2024
0c19a8d
rm input types
jayzhan211 Aug 8, 2024
7226889
rename return_type
jayzhan211 Aug 8, 2024
8d330fa
upd doc
jayzhan211 Aug 8, 2024
96b72e8
move group accumulator adapter to functions-aggregate-common
jayzhan211 Aug 8, 2024
57b0477
Merge branch 'main' of https://github.com/apache/datafusion into udaf…
jayzhan211 Aug 9, 2024
4943b40
fix
jayzhan211 Aug 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ members = [
"datafusion/catalog",
"datafusion/core",
"datafusion/expr",
"datafusion/expr-common",
"datafusion/expr-functions-aggregate",
"datafusion/execution",
"datafusion/functions-aggregate",
"datafusion/functions-aggregate-common",
"datafusion/functions",
"datafusion/functions-nested",
"datafusion/optimizer",
Expand Down Expand Up @@ -94,8 +97,11 @@ datafusion-common = { path = "datafusion/common", version = "40.0.0", default-fe
datafusion-common-runtime = { path = "datafusion/common-runtime", version = "40.0.0" }
datafusion-execution = { path = "datafusion/execution", version = "40.0.0" }
datafusion-expr = { path = "datafusion/expr", version = "40.0.0" }
datafusion-expr-common = { path = "datafusion/expr-common", version = "40.0.0" }
datafusion-expr-functions-aggregate = { path = "datafusion/expr-functions-aggregate", version = "40.0.0" }
datafusion-functions = { path = "datafusion/functions", version = "40.0.0" }
datafusion-functions-aggregate = { path = "datafusion/functions-aggregate", version = "40.0.0" }
datafusion-functions-aggregate-common = { path = "datafusion/functions-aggregate-common", version = "40.0.0" }
datafusion-functions-nested = { path = "datafusion/functions-nested", version = "40.0.0" }
datafusion-optimizer = { path = "datafusion/optimizer", version = "40.0.0", default-features = false }
datafusion-physical-expr = { path = "datafusion/physical-expr", version = "40.0.0", default-features = false }
Expand Down
Loading