Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: migrate lead/lag window function docs to new docs #13095

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

buraksenn
Copy link
Contributor

Which issue does this PR close?

Partially #12936

Rationale for this change

Part of #12740

What changes are included in this PR?

  • migrate to new doc
  • delete lead/lag from static docs

Are these changes tested?

  • documentation change

Are there any user-facing changes?

only documentation change

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2024
@Omega359
Copy link
Contributor

Thank you for migrating this documentation! Would it be possible to add sql examples for each? If not I can file a followup PR to have those added to the docs for these functions and others that may be missing the examples.

@buraksenn
Copy link
Contributor Author

Thank you for migrating this documentation! Would it be possible to add sql examples for each? If not I can file a followup PR to have those added to the docs for these functions and others that may be missing the examples.

I can add for lead/lag now in this PR. When I migrate window functions I can include sql examples

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @buraksenn and @Omega359

Let's merge this PR in now and do the examples as a follow on. I would really like to get to the point where we have all the documentation migrated directly to the new pages.

🚀

@alamb alamb merged commit 9e636d8 into apache:main Oct 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants