Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Consolidate Example: simplify_udwf_expression.rs into advanced_udwf.rs #13883

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore: Consolidate Example: simplify_udwf_expression.rs into advanced_udwf.rs #13883

merged 1 commit into from
Dec 23, 2024

Conversation

xarus01
Copy link
Contributor

@xarus01 xarus01 commented Dec 23, 2024

Which issue does this PR close?

Closes #13843.

Rationale for this change

Part of #11172

What changes are included in this PR?

  • Consolidate contents of simplify_udwf_expression.rs into advanced_udwf.rs.
  • Update docstring referencing simplify_udwf_expression.rs.

Are these changes tested?

Yes.

Are there any user-facing changes?

Updated docstring in datafusion/expr/src/udwf.rs.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Dec 23, 2024
@xarus01 xarus01 changed the title Consolidate Example: simplify_udwf_expression.rs into advanced_udwf.rs chore: Consolidate Example: simplify_udwf_expression.rs into advanced_udwf.rs Dec 23, 2024
@xarus01
Copy link
Contributor Author

xarus01 commented Dec 23, 2024

@alamb - mentioning per contribution guide. Please trigger the CI tasks.

alamb
alamb approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xarus01 -- this looks great 🙏 -

Another step towards getting the code in better shape 🚀

alamb
alamb reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked and it seems this example isn't even listed in the README (so there is no need to update that)

@alamb alamb merged commit 63ba5b6 into apache:main Dec 23, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 23, 2024

Thanks again @xarus01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate Example: simplify_udwf_expression.rs into advanced_udwf.rs #13842
2 participants
@xarus01 @alamb