-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unparsing optimized (> 2 inputs) unions #14031
Conversation
Looks like there's a circular dep between optimizer and SQL packages. The easiest solution is moving the test somewhere else, not sure where though |
Thanks for working on this, @MohamedAbdeen21
If we add the optimization to the testing, the optimizer's behavior will be limited by the unparser but we don't expect it. (see the previous discussion #13267 (comment)) |
Thanks for the suggestion @goldmedal, updated accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohamedAbdeen21. Overall looks good to me. Just some minor comments.
cc @phillipleblanc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @MohamedAbdeen21!
@goldmedal reverted |
Thanks @MohamedAbdeen21 and @phillipleblanc for the review |
Which issue does this PR close?
Closes #13621.
Rationale for this change
Unparsing unions with more than 2 inputs (produced by the logical optimizer)
What changes are included in this PR?
Tests and required changes to unparser
Are these changes tested?
Yes
Are there any user-facing changes?
Should be able to unparse most unions