fix: incorrect error message of function_length_check #14056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonahgao Thanks for reviewing so quickly. |
comphead
reviewed
Jan 9, 2025
| @@ -440,13 +440,13 @@ fn get_valid_types( | |||
| fn function_length_check(length: usize, expected_length: usize) -> Result<()> { | |||
| if length < 1 { | |||
There was a problem hiding this comment.
wondering if this check really needed? would be that enough just to compare with expected_length?
There was a problem hiding this comment.
Makes sense to me to remove this check.
However, if it's required to handle the 0 arg case specifically, it's also reasonable to keep this check.
There was a problem hiding this comment.
hm, I would expect expected_length to be 0 in this case? 🤔
There was a problem hiding this comment.
We can remove this check, 0 arg is handled early in
if current_types.is_empty() {
if type_signature.supports_zero_argument() {
return Ok(vec![]);
} else if type_signature.used_to_support_zero_arguments() {
// Special error to help during upgrade: https://github.com/apache/datafusion/issues/13763
return plan_err!("{} does not support zero arguments. Use TypeSignature::Nullary for zero arguments.", func.name());
} else {
return plan_err!("{} does not support zero arguments.", func.name());
}
}
niebayes
force-pushed
the
fix/function_length_check
branch
from
07aa555 to
f7064f1
Compare
|
Thanks @niebayes @comphead @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
The error message of the
function_length_checkis incorrect.What changes are included in this PR?
Place the
expected_lengthandlengthat where they should be.Are these changes tested?
Yes, added a simple unit test.
Are there any user-facing changes?
Yes, users will see correct error message when given unexpected number of args.