feat: Add regexp_substr function #14323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
Is this materially different than #14282 ? |
Omega359
reviewed
Jan 27, 2025
| let cleaned_value = if let Some(start) = start { | ||
| if start < 1 { | ||
| return Err(DataFusionError::from(ArrowError::ComputeError( | ||
| "regexp_count() requires start to be 1 based".to_string(), |
There was a problem hiding this comment.
Suggested change
| "regexp_count() requires start to be 1 based".to_string(), | |
| "regexp_substr() requires start to be 1 based".to_string(), |
Omega359
reviewed
Jan 27, 2025
|
|
||
| static DOCUMENTATION: OnceLock<Documentation> = OnceLock::new(); | ||
|
|
||
| fn get_regexp_substr_doc() -> &'static Documentation { |
There was a problem hiding this comment.
We may want to use the new doc macro as it's been incorporated into most every udf at this point.
Omega359
reviewed
Jan 27, 2025
| // Planner attempts coercion to the target type starting with the most preferred candidate. | ||
| // For example, given input `(Utf8View, Utf8)`, it first tries coercing to `(Utf8, Utf8)`. | ||
| // If that fails, it proceeds to `(LargeUtf8, Utf8)`. | ||
| TypeSignature::Exact(vec![Utf8, Utf8]), |
There was a problem hiding this comment.
We likely want to include Utf8View into this signature.
|
Thank you for your contribution! I have 2 concerns:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11946
Rationale for this change
Implementation for
regexp_substr()
regexp_substr()
What changes are included in this PR?
Add regex udf that returns the substring that matches a regular expression within a string.
Are there any user-facing changes?
No user-facing changes since this is a new functionality