moving memory.rs out of datafusion/core

[logan-keede]

Which issue does this PR close?

Closes part of #10782

Rationale for this change

What changes are included in this PR?

moved memory.rs from datafusion/core/catalog_common to datafusion/catalog

Are these changes tested?

Are there any user-facing changes?

[logan-keede]

I am not sure if this is the correct place/way to put this.

[alamb]

I think this looks good

One way to review this is to run cargo --doc --open and then looking at how it is rendered

[logan-keede]

@alamb can this please get a review?
Thanks,
Logan

[comphead]

Thanks @logan-keede
I'm thinking we should rename memory.rs to memory_catalog_provider.rs otherwise its really confusing, I thought originally its memory pool related crate but it is catalog related.

WDYT?

[logan-keede]

Thanks @logan-keede I'm thinking we should rename memory.rs to memory_catalog_provider.rs otherwise its really confusing, I thought originally its memory pool related crate but it is catalog related.

WDYT?

Welcome, I think memory_catalog_provider.rs is too specific given that the same file also covers MemorySchemaProvider, given that similar pattern is being followed by almost all the files(look at async.rs), we can assume that any developer working on that set of file will notice it too.
However, if you think that might cause inefficiency we can go with something like memory_providers, again, for consistency's sake if we go with that we should change name of every similar file in a similar manner (atleast async.rs).

I am not sure if this is the correct place/way to put this.

any idea/comment?

[comphead]

if we go with that we should change name of every similar file in a similar manner (atleast async.rs).

That is true, to be consistent it needs to be fixed for all files which is not part of this PR for sure

[comphead]

lgtm thanks @logan-keede

[alamb]

😍

[alamb]

Thank you @logan-keede and @comphead ❤️

[alamb]

I think this looks good

One way to review this is to run cargo --doc --open and then looking at how it is rendered

[comphead]

One way to review this is to run cargo --doc --open and then looking at how it is rendered

Oh this is much easier way than I kept doing before, thanks