datafusion-cli: Use correct S3 region if it is not specified #16502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamzwbao
force-pushed
the
issue-13456-resolve-region-on-error
branch
4 times, most recently
from
fa796a8 to
1800fc4
Compare
liamzwbao
force-pushed
the
issue-13456-resolve-region-on-error
branch
from
1800fc4 to
126b9e1
Compare
|
Hi @alamb, this PR is ready for review! One concern here is whether it is acceptable to test against a bucket outside of datafusion, but I couldn’t find a good way to test region retry against local minio. |
|
Thanks @liamzwbao -- I'll put this one on my review queue for tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-cli: Use correct S3 region if it is not specified #16306.Rationale for this change
Improve UX by resolving s3 region automatically.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Yes, the CLI can automatically resolve the region for bucket now