Fix WindowFrame::new with order_by #16537
Merged
+299
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting expected data second allows for natural inlining of expected values.
github-actions
bot
added
logical-expr
findepi
force-pushed
the
findepi/window
branch
2 times, most recently
from
be53501 to
4ad54f8
Compare
Before the change, the frame constructed with `WindowFrame::new(Some(true))` would not be fully functional, because of the bound being of unexpected type.
alamb
approved these changes
Jun 24, 2025
findepi
added a commit
to sdf-labs/arrow-datafusion
that referenced
this pull request
Jun 25, 2025
* Fix WindowFrame::new with order_by Before the change, the frame constructed with `WindowFrame::new(Some(true))` would not be fully functional, because of the bound being of unexpected type. * Change assert helper param order Putting expected data second allows for natural inlining of expected values. (cherry picked from commit 20a723b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Before the change, the frame constructed with
WindowFrame::new(Some(true))would not be fully functional, becauseof the bound being of unexpected type.
What changes are included in this PR?
Change in
WindowFrame::newAre these changes tested?
with unit tests
Are there any user-facing changes?
yes