chore: use equals_datatype for BinaryExpr
#16813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Jul 18, 2025
Added |
34 tasks
comphead
added a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 21, 2025
* chore: use `equals_datatype` instead of direct type comparison for `BinaryExpr` * chore: use `equals_datatype` instead of direct type comparison for `BinaryExpr` (cherry picked from commit acff1b6)
alamb
pushed a commit
that referenced
this pull request
Jul 22, 2025
* chore: use `equals_datatype` instead of direct type comparison for `BinaryExpr` * chore: use `equals_datatype` instead of direct type comparison for `BinaryExpr` (cherry picked from commit acff1b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Current type check in
BinaryExpris erroneous(it doesn't consider element names diff for nested types) and the error message is overly unclear.Found working on apache/datafusion-comet#1978
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?