[branch-50]: fix: Add overflow checks to SparkDateAdd/Sub to avoid panics (#18013) #18131
+54
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18013) * fix * fix * fix * fix * fix * add negative overflow test * remove unrelated test * update test
This was referenced Oct 17, 2025
alamb
changed the title
alamb
approved these changes
Oct 17, 2025
|
Merging to pick up #18141 and try and get a clean CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DateAdd/DateSubdo not perform overflow checks in release builds datafusion-comet#253950.3.0(minor) #18072Rationale for this change
Return errors rather than panicking.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?